docs: mTLS documentation with example sample #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Oct 28, 2025
|
|
||
| --- | ||
|
|
||
| ## How mTLS Works |
|
|
||
| --- | ||
|
|
||
| ## Complete Working Example |
Member
There was a problem hiding this comment.
maybe add another section of How to enable mTLS?
demirkayaender
requested changes
Oct 28, 2025
docs/03-concepts/14-mutual-tls.md
Outdated
|
|
||
| ## Complete Working Example | ||
|
|
||
| For a complete working example with detailed code and configuration, refer to the [helloworld_tls sample](https://github.com/cadence-workflow/cadence-samples/tree/master/new_samples/client_samples/helloworld_tls) in the Cadence samples repository. This sample demonstrates how to: |
Member
There was a problem hiding this comment.
Could you update the samples change explaining how this command works?
./cadence-server --env development --zone tls start
| │ All subsequent data is encrypted │ | ||
| │ │ | ||
| ``` | ||
|
|
Member
There was a problem hiding this comment.
Add a section here explaining how mTLS works with Cadence, explaining creating gRPC options, then the gRPC transport object and Cadence using it (how client is initialized). Leave links to the sample changes and the client repo.
Similarly please leave pointers to server code, explaining how a secure server is started.
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
demirkayaender
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats new
In mTLS, both the client and server have a certificate, and both sides authenticate using their public/private key pair.
Steps:
Testing Scenarios:
